fix: keyboard on focus #1420
Merged
fix: keyboard on focus #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
thanks @beqramo! |
gorhom
added a commit
that referenced
this pull request
Jul 15, 2023
…qramo) * fix: keyboard on focus * fix: updated containerOffset top value to default to 0 --------- Co-authored-by: Mo Gorhom <[email protected]>
|
Any idea when this fix will be live? I don't see it in 4.4.7. Any estimation would be very helpful, thanks! |
Contributor
Author
|
Hi, |
tell me , which package , i am confused becuase i installed lots of package |
Update: False alarm., sorry. It's working now that I switched from React Native Paper's TextInput to BottomSheetTextInput. To take control of this virtual keyboard behavior seems to require BottomSheetTextInput. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1328
Motivation
Sometimes, especially when the view is newly created
measurefunction return undefined onPageYthat was causing hiding modal behind the keyboard asanimatedContainerOffset.value.bottomwasNaNinBottomSheet.tsxfileWith this change, I'm passing the default value 0 so that it will not have the bug.
With the current change, everything is working fine on both platforms.
Thanks