Skip to content

fix: crash on swipe down #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2023
Merged

fix: crash on swipe down #1367

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a718b7b
fix: crash on swipe down
beqramo May 11, 2023
efbe369
fix: keyboard dismiss on JS thread
beqramo Jun 2, 2023
49258cc
fix: call the keyboard dismiss method
gorhom Jun 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hooks/useGestureEventsHandlersDefault.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type GestureEventContextType = {
isScrollablePositionLocked: boolean;
};

const dismissKeyboardOnJs = runOnJS(Keyboard.dismiss);
const dismissKeyboard = Keyboard.dismiss

export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =
() => {
Expand Down Expand Up @@ -298,7 +298,7 @@ export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =
absoluteY > WINDOW_HEIGHT - animatedKeyboardHeight.value
)
) {
dismissKeyboardOnJs();
runOnJS(dismissKeyboard)
}
}

Expand Down