Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Popups blocks "Open in New Tab" on some sites. #44

Closed
ghost opened this issue Apr 13, 2015 · 2 comments
Closed

Block Popups blocks "Open in New Tab" on some sites. #44

ghost opened this issue Apr 13, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 13, 2015

On some sites, disabling popups causes the right click "Open in New Tab" to not function, or the tab to be immediately closed. I'm not sure if all sites should behave this way due to aggressive popup checks, or not, but I would think that me right clicking a browser context menu (I don't know if this is in any way distinguishable in the API or not) would never be a popup.

Some sites are OK, an example is GitHub itself. I can block all popups just fine.

On this site however (http://www.nextgenupdate.com/forums/grand-theft-auto-v/), I can see that the Open in New Tab is detected as a popup and terminated/blocked.

I also tested via the inspector to force a target="_blank" on the link, though I'd see that more exploitable by popups than a browser menu click.

@gorhill
Copy link
Owner

gorhill commented Apr 13, 2015

Yes this was reported before: uBlock-LLC/uBlock#1143.

Unfortunately, this is caused by a limitation of chrome API: it is not possible for the code to reliably find out whether a tab opened because a user opened the link or because javascript opened the link.

The block-all-popups feature should be seen as a last resort tool for when a site creates nuisance popups and there are no static filters (yet) for these. Workaround is to copy-link-address and paste manually.

@gorhill gorhill closed this as completed Apr 13, 2015
@ghost
Copy link
Author

ghost commented Apr 13, 2015

I was afraid they wouldn't have had a reliable method to detect the click source.

Well I'll just use it site-specific if I ever see popups. I haven't seen bad popups in forever anyway.

@gorhill gorhill reopened this Sep 10, 2015
gorhill added a commit that referenced this issue Sep 10, 2015
Disregard no-popups per-site switch for a URL which matches
a link clicked by the user.
@gorhill gorhill closed this as completed Sep 10, 2015
gorhill added a commit that referenced this issue Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant