Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM cpio name contains the release twice #714

Closed
2 tasks done
WeirdBob opened this issue Sep 21, 2023 · 3 comments · Fixed by #715
Closed
2 tasks done

RPM cpio name contains the release twice #714

WeirdBob opened this issue Sep 21, 2023 · 3 comments · Fixed by #715
Assignees
Labels
bug Something isn't working

Comments

@WeirdBob
Copy link

What happened?

Hi, in v2.33.0, there is a new bug regarding the generation of an RPM.
using the minimal description file attached, the generated RPM is called test-1.2.3-1.x86_64.rpm (correct) but contains test-1.2.3-1-1.x86_64.cpio (not correct, release is used twice).
With v2.32.0, the rpm and cpio are correctly named.

How can we reproduce this?

test.yaml :

name: "test"
version: 1.2.3
contents:
  - src: test
    dst: test

go install github.com/goreleaser/nfpm/v2/cmd/[email protected]
nfpm pkg --config test.yaml --packager rpm

nfpm version

_____ ____  __  __
 _ __ |  ___|  _ \|  \/  |
| '_ \| |_  | |_) | |\/| |
| | | |  _| |  __/| |  | |
|_| |_|_|   |_|   |_|  |_|
nfpm: a simple and 0-dependencies deb, rpm, apk and arch linux packager written in Go
https://nfpm.goreleaser.com

GitVersion:    dev
GitCommit:     unknown
GitTreeState:  unknown
BuildDate:     unknown
BuiltBy:       unknown
GoVersion:     go1.21.1
Compiler:      gc
ModuleSum:     h1:yBv6jgkPwih4va/S42rceSjJ2Znt3Og/Ntc76oP0tfI=
Platform:      windows/amd64

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@WeirdBob WeirdBob added the bug Something isn't working label Sep 21, 2023
@atc0005
Copy link

atc0005 commented Sep 21, 2023

See also:

I too noticed the behavior described in this GH issue (#714), but wasn't sure if the behavior was intended.

@caarlos0
Copy link
Member

releasing a patch rn

@caarlos0
Copy link
Member

thanks for reporting :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants