Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added failing tests #8

Merged
merged 4 commits into from
Nov 9, 2020
Merged

test: added failing tests #8

merged 4 commits into from
Nov 9, 2020

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 9, 2020

adding some failing tests we need to make pass...

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 self-assigned this Nov 9, 2020
@caarlos0 caarlos0 requested a review from erikgeiser November 9, 2020 14:04
@erikgeiser
Copy link
Member

The first test should fail. If the pattern is escaped, it matches the file name that is equal to the unescaped pattern. In other words, the QuoteMeta in the mock file system is wrong.

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #8 (a3c0563) into main (6c2892c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   82.97%   82.97%           
=======================================
  Files           2        2           
  Lines          94       94           
=======================================
  Hits           78       78           
  Misses          9        9           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c2892c...a3c0563. Read the comment docs.

@caarlos0 caarlos0 merged commit b27e0ce into main Nov 9, 2020
@caarlos0 caarlos0 deleted the test branch November 9, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants