fix: [#533] there is a bug when validating nested data #751

hwbrzzl · 2024-12-11T10:15:22Z

📑 Description

Closes goravel/goravel#533

@coderabbitai summary

✅ Checks

Added test cases for my code

coderabbitai · 2024-12-11T10:15:31Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

hwbrzzl · 2024-12-11T10:21:10Z

validation/validator.go

@@ -129,19 +129,6 @@ func (v *Validator) castValue() mapstructure.DecodeHookFunc {
 			default:
 				castedValue, err = cast.ToSliceE(from.Interface())
 			}
-		case reflect.Map:


The map structure is not fixed, so we can cast the value to StringMapString, StringMapBool, etc. And there is a BUG as well, to.Type().Key().Kind() checks the map key, but in the case logic, we are using ToStringMapBoolE, it should be ToBoolMap***E.

I think we can remove the logic directly.

hwbrzzl · 2024-12-12T03:12:29Z

support/docker/sqlserver.go

@@ -28,22 +28,19 @@ func NewSqlserver(database, username, password string) *Sqlserver {
 		username: username,
 		password: password,
 		image: &testing.Image{
-			Repository: "mcmoe/mssqldocker",
+			Repository: "mcr.microsoft.com/mssql/server",


The mssql image is unavailable, the CI failed, so modify it in this PR.

codecov · 2024-12-12T04:17:14Z

Codecov Report

Attention: Patch coverage is 63.63636% with 20 lines in your changes missing coverage. Please review.

Please upload report for BASE (v1.14.x@d4de868). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
support/docker/sqlserver.go	63.63%	12 Missing and 8 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             v1.14.x     #751   +/-   ##
==========================================
  Coverage           ?   69.42%           
==========================================
  Files              ?      176           
  Lines              ?    13246           
  Branches           ?        0           
==========================================
  Hits               ?     9196           
  Misses             ?     3476           
  Partials           ?      574

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix:[#533] there is a bug when validating nested data

6ba1359

hwbrzzl added 2 commits December 11, 2024 18:16

fix mod

a7bc32a

Merge branch 'v1.14.x' into bowen/#533

c75e658

hwbrzzl commented Dec 11, 2024

View reviewed changes

hwbrzzl changed the title ~~fix:[#533] there is a bug when validating nested data~~ fix: [#533] there is a bug when validating nested data Dec 11, 2024

hwbrzzl added the 🚀 Review Ready label Dec 12, 2024

fix sqlserver docker image

1756dd9

hwbrzzl commented Dec 12, 2024

View reviewed changes

fix sqlservefr

f7e5b84

hwbrzzl merged commit 20c6d6d into v1.14.x Dec 12, 2024
10 checks passed

hwbrzzl deleted the bowen/#533 branch December 12, 2024 07:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: [#533] there is a bug when validating nested data #751

fix: [#533] there is a bug when validating nested data #751

hwbrzzl commented Dec 11, 2024

coderabbitai bot commented Dec 11, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

hwbrzzl Dec 11, 2024

hwbrzzl Dec 12, 2024

codecov bot commented Dec 12, 2024

fix: [#533] there is a bug when validating nested data #751

fix: [#533] there is a bug when validating nested data #751

Conversation

hwbrzzl commented Dec 11, 2024

📑 Description

✅ Checks

coderabbitai bot commented Dec 11, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

hwbrzzl Dec 11, 2024

Choose a reason for hiding this comment

hwbrzzl Dec 12, 2024

Choose a reason for hiding this comment

codecov bot commented Dec 12, 2024

Codecov Report

coderabbitai bot commented Dec 11, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)