Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Exists method #421

Merged
merged 3 commits into from
Feb 15, 2024
Merged

feat: add Exists method #421

merged 3 commits into from
Feb 15, 2024

Conversation

Kamandlou
Copy link
Contributor

@Kamandlou Kamandlou commented Feb 14, 2024

πŸ“‘ Description

add Exists method

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (a4e9b9a) 69.89% compared to head (96171b2) 69.91%.
Report is 1 commits behind head on master.

❗ Current head 96171b2 differs from pull request most recent head 370cc6d. Consider uploading reports for the commit 370cc6d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   69.89%   69.91%   +0.01%     
==========================================
  Files         161      161              
  Lines        9467     9469       +2     
==========================================
+ Hits         6617     6620       +3     
+ Misses       2310     2309       -1     
  Partials      540      540              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@Kamandlou
Copy link
Contributor Author

Dear @hwbrzzl, this PR is ready to review but I don't have access to add Review Ready tag.
Screenshot from 2024-02-15 02-19-37

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@hwbrzzl
Copy link
Contributor

hwbrzzl commented Feb 15, 2024

Dear @hwbrzzl, this PR is ready to review but I don't have access to add Review Ready tag. Screenshot from 2024-02-15 02-19-37

Oh, sorry, just know this, you can pin me directly like now.

@hwbrzzl hwbrzzl merged commit 1a9f352 into goravel:master Feb 15, 2024
8 checks passed
@Kamandlou Kamandlou deleted the Exists branch February 15, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants