Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OrWhereBetween and OrWhereNotBetween methods #417

Merged
merged 3 commits into from
Feb 14, 2024
Merged

feat: add OrWhereBetween and OrWhereNotBetween methods #417

merged 3 commits into from
Feb 14, 2024

Conversation

Kamandlou
Copy link
Contributor

@Kamandlou Kamandlou commented Feb 12, 2024

πŸ“‘ Description

add OrWhereBetween and OrWhereNotBetween methods

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (c12a383) 69.91% compared to head (80ed3cf) 69.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   69.91%   69.92%   +0.01%     
==========================================
  Files         161      161              
  Lines        9463     9467       +4     
==========================================
+ Hits         6616     6620       +4     
  Misses       2308     2308              
  Partials      539      539              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, please add the Review Ready tag next time when the PR is ready for review.

image

@hwbrzzl hwbrzzl merged commit a4e9b9a into goravel:master Feb 14, 2024
10 checks passed
@Kamandlou Kamandlou deleted the where-between-methods branch February 14, 2024 07:26
@Kamandlou
Copy link
Contributor Author

Great PR, please add the Review Ready tag next time when the PR is ready for review.

image

Sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants