feat: Add Map helpers #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 41.88% 42.06% +0.17%
==========================================
Files 271 272 +1
Lines 16245 16295 +50
==========================================
+ Hits 6804 6854 +50
Misses 8835 8835
Partials 606 606 ☔ View full report in Codecov by Sentry. |
hwbrzzl
reviewed
Feb 5, 2024
support/object/object.go
Outdated
| ) | ||
|
|
||
| // Add an element to a map using “dot” notation if it doesn't exist. | ||
| func Add(obj *map[string]any, k string, v any) error { |
There was a problem hiding this comment.
We only support string as a key so there is no point of using generic.
|
Hi Bro, If this PR is ready for review, please add the |
|
As we discussed, I can't implement nested key feature for all cases. So I am not working on this feature anymore. |
|
Some of the methods are good, don't you want to merge them? |
hwbrzzl
reviewed
Feb 9, 2024
hwbrzzl
reviewed
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RelatedTo: goravel/goravel#82
📑 Description
This pull request introduces a set of map helper methods to enhance map manipulation in Go.
Supported Methods
Add: Add an element to a map if it doesn't exist.Exists: Check if the given key exists in the provided map.Forget: Remove a given key or keys from the provided map.Get: Retrieve an element from map.Has: Check if the given key or keys exist in the provided map.HasAny: Check if any of the given keys exist in the provided map.Only: Return the items in the map with the specified keys.Pull: Return a new map with the specified keys removed.Set: Set an element to a map using “dot” notation.Where: filters the items in a map using the given callback.✅ Checks