Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add InRandomOrder method #405

Merged
merged 8 commits into from
Feb 4, 2024
Merged

feat: add InRandomOrder method #405

merged 8 commits into from
Feb 4, 2024

Conversation

Kamandlou
Copy link
Contributor

@Kamandlou Kamandlou commented Feb 1, 2024 •
edited
Loading

📑 Description

add InRandomOrder method

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c33b6e) 70.60% compared to head (71235c6) 70.66%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   70.60%   70.66%   +0.06%     
==========================================
  Files         152      152              
  Lines        9067     9079      +12     
==========================================
+ Hits         6402     6416      +14     
+ Misses       2159     2157       -2     
  Partials      506      506

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hwbrzzl
hwbrzzl requested changes Feb 2, 2024
View reviewed changes
database/gorm/query.go Outdated Show resolved Hide resolved
database/gorm/query_test.go Outdated Show resolved Hide resolved
@Kamandlou Kamandlou requested a review from hwbrzzl February 3, 2024 11:41
@Kamandlou Kamandlou requested a review from hwbrzzl February 3, 2024 16:15
hwbrzzl
hwbrzzl approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@hwbrzzl hwbrzzl merged commit 6add0f2 into goravel:master Feb 4, 2024
10 checks passed
@Kamandlou Kamandlou deleted the InRandomOrder branch February 4, 2024 08:17
@Kamandlou Kamandlou mentioned this pull request Feb 16, 2024
Closed
1 task
hwbrzzl added a commit that referenced this pull request May 16, 2024
@hwbrzzl
fix: [#405] The GetAttribute of orm event returns an error value when…
eb83982 
… getting id
hwbrzzl added a commit that referenced this pull request May 19, 2024
@hwbrzzl
fix: [#405] The GetAttribute of orm event returns an error value when…
a631db1 
… getting id (#478)

* fix: [#405] The GetAttribute of orm event returns an error value when getting id

* fix unit test

* optimize lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kamandlou @hwbrzzl