Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OrWhereNotIn and WhereNotIn methods #399

Merged
merged 5 commits into from
Jan 30, 2024
Merged

feat: add OrWhereNotIn and WhereNotIn methods #399

merged 5 commits into from
Jan 30, 2024

Conversation

Kamandlou
Copy link
Contributor

πŸ“‘ Description

Add OrWhereNotIn and WhereNotIn methods

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (2e2c84a) 69.37% compared to head (fa39dc7) 69.38%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   69.37%   69.38%   +0.01%     
==========================================
  Files         152      152              
  Lines       10937    10941       +4     
==========================================
+ Hits         7587     7591       +4     
  Misses       2844     2844              
  Partials      506      506              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

database/gorm/query_test.go Outdated Show resolved Hide resolved
s.Nil(query.Create(&user2))
s.True(user2.ID > 0)

var users []User
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I do in this line?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better create user2, then judge users contains user2.

@Kamandlou Kamandlou requested a review from hwbrzzl January 29, 2024 18:14
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great πŸ‘

@hwbrzzl hwbrzzl merged commit e503ecf into goravel:master Jan 30, 2024
10 checks passed
@Kamandlou Kamandlou deleted the orm branch January 30, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants