feat: add WhereIn method #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwbrzzl
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Looks great, thank Bro! Ci failed, could you please install Mockery and regenerate the interface?
go install github.com/vektra/mockery/[email protected]
mockery --all --keeptree --dir=contracts
contracts/database/orm/orm.go
Outdated
Comment on lines
132
to
133
| // WhereIn adds a "where column in" clause to the query. | ||
| WhereIn(column string, values []any) Query |
There was a problem hiding this comment.
S: Please move this method after Where.
database/gorm/query_test.go
Outdated
|
|
||
| var users []User | ||
| s.Nil(query.WhereIn("id", []any{user.ID, user1.ID}).Find(&users)) | ||
| s.True(len(users) > 0) |
There was a problem hiding this comment.
Suggested change
| s.True(len(users) > 0) | |
| s.True(len(users) == 2) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
=======================================
Coverage 69.35% 69.36%
=======================================
Files 152 152
Lines 10933 10935 +2
=======================================
+ Hits 7583 7585 +2
Misses 2844 2844
Partials 506 506 ☔ View full report in Codecov by Sentry. |
|
Good job @Kamandlou |
hwbrzzl
approved these changes
Jan 26, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Add
WhereInmethod✅ Checks