feat: Context can be passed to facades.Auth() directly, and other methods of Auth don't need to pass Contect anymore #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devhaozi
approved these changes
Dec 17, 2023
hwbrzzl
reviewed
Dec 17, 2023
| guard string | ||
| orm orm.Orm | ||
| } | ||
|
|
||
| func NewAuth(guard string, cache cache.Cache, config config.Config, orm orm.Orm) *Auth { | ||
| func NewAuth(guard string, cache cache.Cache, config config.Config, ctx http.Context, orm orm.Orm) *Auth { |
There was a problem hiding this comment.
nitpick: ctx is usually in the first parameter.
Suggested change
| func NewAuth(guard string, cache cache.Cache, config config.Config, ctx http.Context, orm orm.Orm) *Auth { | |
| func NewAuth(ctx http.Context, guard string, cache cache.Cache, config config.Config, orm orm.Orm) *Auth { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes goravel/goravel#329
📑 Description
✅ Checks
ℹ Additional Information