Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: The lang json file supports nested folder and key. #371

Merged
merged 23 commits into from
Jan 12, 2024
Merged

feat: The lang json file supports nested folder and key. #371

merged 23 commits into from
Jan 12, 2024

Conversation

kkumar-gcc
Copy link
Member

@kkumar-gcc kkumar-gcc commented Dec 16, 2023 •
edited
Loading

Closes goravel/goravel#319

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@kkumar-gcc kkumar-gcc requested a review from a team December 16, 2023 12:44
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5bb48b5) 69.26% compared to head (55cb1fe) 69.35%.

Files Patch % Lines
translation/service_provider.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   69.26%   69.35%   +0.09%     
==========================================
  Files         152      152              
  Lines       10922    10933      +11     
==========================================
+ Hits         7565     7583      +18     
+ Misses       2849     2844       -5     
+ Partials      508      506       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

devhaozi
devhaozi requested changes Dec 17, 2023
View reviewed changes
translation/translator.go Outdated Show resolved Hide resolved
hwbrzzl
hwbrzzl reviewed Dec 17, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

translation/translator.go Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/file_loader.go Show resolved Hide resolved
translation/file_loader_test.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
contracts/translation/loader.go Outdated Show resolved Hide resolved
translation/translator_test.go Show resolved Hide resolved
translation/translator_test.go Show resolved Hide resolved
translation/translator_test.go Show resolved Hide resolved
translation/translator_test.go Show resolved Hide resolved
hwbrzzl
hwbrzzl reviewed Dec 19, 2023
View reviewed changes
translation/file_loader.go Outdated Show resolved Hide resolved
translation/file_loader.go Outdated Show resolved Hide resolved
translation/file_loader_test.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator_test.go Outdated Show resolved Hide resolved
hwbrzzl
hwbrzzl reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, almost finished.

translation/file_loader_test.go Show resolved Hide resolved
translation/file_loader_test.go Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
hwbrzzl
hwbrzzl reviewed Dec 24, 2023
View reviewed changes
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Show resolved Hide resolved
hwbrzzl
hwbrzzl reviewed Dec 25, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, the test passed locally, only left a few performance optimizations.

translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
translation/translator.go Outdated Show resolved Hide resolved
@kkumar-gcc kkumar-gcc requested a review from hwbrzzl January 11, 2024 19:31
hwbrzzl
hwbrzzl approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Bro. The BeforeTest method is unnecessary, I removed it directly. Please @devhaozi make an approval.

image

devhaozi
devhaozi approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkumar-gcc kkumar-gcc merged commit f062ca8 into master Jan 12, 2024
10 checks passed
@kkumar-gcc kkumar-gcc deleted the kkumar-gcc/#319 branch January 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devhaozi devhaozi devhaozi approved these changes

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
🚀 Review Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] The lang json file supports nested folder and key.
3 participants
@kkumar-gcc @hwbrzzl @devhaozi