Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: The HTTP module supports set Cookie #369

Merged
merged 7 commits into from
Dec 14, 2023
Merged

feat: The HTTP module supports set Cookie #369

merged 7 commits into from
Dec 14, 2023

Conversation

kkumar-gcc
Copy link
Member

Closes goravel/goravel#271

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@kkumar-gcc kkumar-gcc requested a review from a team December 14, 2023 10:22
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18dab42) 69.25% compared to head (c60fa8a) 69.25%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #369   +/-   ##
=======================================
  Coverage   69.25%   69.25%           
=======================================
  Files         152      152           
  Lines       10919    10919           
=======================================
  Hits         7562     7562           
  Misses       2849     2849           
  Partials      508      508

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkumar-gcc kkumar-gcc mentioned this pull request Dec 14, 2023
Merged
4 tasks
hwbrzzl
hwbrzzl reviewed Dec 14, 2023
View reviewed changes
contracts/http/cookie.go Outdated Show resolved Hide resolved
contracts/http/response.go Outdated Show resolved Hide resolved
contracts/http/response.go Outdated Show resolved Hide resolved
contracts/http/response.go Outdated Show resolved Hide resolved
hwbrzzl
hwbrzzl approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@kkumar-gcc kkumar-gcc merged commit ea46f55 into master Dec 14, 2023
10 checks passed
@kkumar-gcc kkumar-gcc deleted the kkumar-gcc/#271 branch December 14, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [Feature] The HTTP module supports set Cookie
2 participants
@kkumar-gcc @hwbrzzl