Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: facades.Log().Tags() does not clear tags after writing the log #366

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

kkumar-gcc
Copy link
Member

Closes goravel/goravel#335

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@kkumar-gcc kkumar-gcc changed the title bug: facades.Log().Tags() does not clear tags after writing the log fix: facades.Log().Tags() does not clear tags after writing the log Dec 10, 2023
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (e7c94bf) 69.22% compared to head (725d6e7) 69.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
+ Coverage   69.22%   69.26%   +0.03%     
==========================================
  Files         152      152              
  Lines       10904    10918      +14     
==========================================
+ Hits         7548     7562      +14     
  Misses       2848     2848              
  Partials      508      508              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi devhaozi merged commit 5e795de into master Dec 11, 2023
9 of 10 checks passed
@devhaozi devhaozi deleted the kkumar-gcc/#335 branch December 11, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› [Bug] facades.Log().Tags() does not clear tags after writing the log
2 participants