Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The trace of Log doesn't make a new line when calling with the Request method #362

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

kkumar-gcc
Copy link
Member

@kkumar-gcc kkumar-gcc commented Dec 5, 2023

Closes:goravel/goravel#330 goravel/goravel#332

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (7eea869) 69.21% compared to head (d4e4f7c) 69.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   69.21%   69.22%           
=======================================
  Files         152      152           
  Lines       10901    10904    +3     
=======================================
+ Hits         7545     7548    +3     
  Misses       2848     2848           
  Partials      508      508           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Please merge this to v1.13.x

@kkumar-gcc kkumar-gcc merged commit 0d87492 into master Dec 5, 2023
10 checks passed
@kkumar-gcc kkumar-gcc deleted the kkumar-gcc/#330-332 branch December 5, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants