Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement email locally #360

Merged
merged 2 commits into from
Dec 4, 2023
Merged

feat: implement email locally #360

merged 2 commits into from
Dec 4, 2023

Conversation

devhaozi
Copy link
Member

@devhaozi devhaozi commented Dec 3, 2023

Closes #

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@devhaozi devhaozi requested a review from a team December 3, 2023 16:56
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 262 lines in your changes are missing coverage. Please review.

Comparison is base (251c078) 70.04% compared to head (6c0a493) 69.21%.

Files Patch % Lines
mail/mail.go 54.13% 224 Missing and 37 partials ⚠️
mail/application.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   70.04%   69.21%   -0.84%     
==========================================
  Files         151      152       +1     
  Lines       10332    10901     +569     
==========================================
+ Hits         7237     7545     +308     
- Misses       2624     2848     +224     
- Partials      471      508      +37     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Do we copy it from jordan-wright/email directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Do we copy it from jordan-wright/email directly?

Yes, and I fix some lint errors.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@devhaozi devhaozi merged commit 9b0912f into master Dec 4, 2023
9 of 11 checks passed
@devhaozi devhaozi deleted the haozi/mail branch December 4, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants