feat: [#289] Remove github.com/ory/dockertest #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
==========================================
- Coverage 69.31% 69.08% -0.23%
==========================================
Files 144 147 +3
Lines 9724 9922 +198
==========================================
+ Hits 6740 6855 +115
- Misses 2550 2598 +48
- Partials 434 469 +35 β View full report in Codecov by Sentry. |
hwbrzzl
commented
Nov 15, 2023
database/console/main_test.go
Outdated
There was a problem hiding this comment.
The database docker only needs to be created once, the testing speed will be faster.
hwbrzzl
commented
Nov 15, 2023
| query ormcontract.Query | ||
| ) | ||
|
|
||
| if err := testDatabaseDocker.Fresh(); err != nil { |
There was a problem hiding this comment.
Fresh the database, and clear data from other test cases.
devhaozi
reviewed
Nov 15, 2023
support/docker/redis.go
Outdated
Comment on lines
7
to
8
|
|
||
| "github.com/go-redis/redis/v8" |
There was a problem hiding this comment.
Q: Can we use v9? v8 is out.
There was a problem hiding this comment.
Good catch, will upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes goravel/goravel#289 goravel/goravel#261
π Description
β Checks
βΉ Additional Information