-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating docs from wiki #107
Conversation
Need to fix images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Other suggestions:
- Change
Home.md
toREADME.md
so that it auto-renders from the docs folder - Update root
README.md
links to docs instead of wiki
While I'm working on fixing the images and adding your suggestions I do have a concern... The docs add a bunch of images that are going to get cloned down to work on pixel... I don't think go will download them since they're not in a go package |
hmmmmm.... good point. Not terribly worried about it in terms of git clone time. Having go fetch them would be a bit strange. Should be relatively easy to validate that right? |
Looks like it didn't download the images, just the markdown
|
Awesome! Thanks for validating that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Addresses #104