-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yap: classfile v2 #94
Conversation
if me, ok := app.(interface{ MainEntry() }); ok { | ||
me.MainEntry() | ||
} else { | ||
app.Run(":8080") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci-lint] Error return value of app.Run
is not checked (errcheck)
If you have any questions about this comment, feel free to raise an issue here:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage 89.36% 89.36%
=======================================
Files 10 10
Lines 94 94
=======================================
Hits 84 84
Misses 10 10 ☔ View full report in Codecov by Sentry. |
@@ -0,0 +1,3 @@ | |||
yap "article", { | |||
"id": param("id"), | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci-lint] invalid character U+0023 '#'
If you have any questions about this comment, feel free to raise an issue here:
@@ -0,0 +1,3 @@ | |||
yap "article", { | |||
"id": param("id"), | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci-lint] syntax error: unexpected id in parameter list; possibly missing comma or ) (typecheck)
If you have any questions about this comment, feel free to raise an issue here:
@@ -0,0 +1,3 @@ | |||
json { | |||
"id": param("id"), | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci-lint] invalid character U+0023 '#'
If you have any questions about this comment, feel free to raise an issue here:
@@ -0,0 +1,3 @@ | |||
json { | |||
"id": param("id"), | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci-lint] syntax error: unexpected id in parameter list; possibly missing comma or ) (typecheck)
If you have any questions about this comment, feel free to raise an issue here:
No description provided.