Skip to content

ci:avoid auto upgrade before brew install#1388

Merged
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:ci/no-auto-update
Nov 10, 2025
Merged

ci:avoid auto upgrade before brew install#1388
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:ci/no-auto-update

Conversation

@luoliwoshang
Copy link
Member

@luoliwoshang luoliwoshang commented Nov 6, 2025

fix ci fail at install dependency

==> Upgrading python@3.13
  3.13.8 -> 3.13.9_1 
==> Pouring python@3.13--3.13.9_1.sequoia.bottle.tar.gz
Error: The `brew link` step did not complete successfully

@gemini-code-assist
Copy link

Summary of Changes

Hello @luoliwoshang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor but impactful change to the continuous integration setup for macOS environments. By configuring Homebrew to avoid automatic updates during package installations, the aim is to enhance the predictability and potentially improve the execution speed of CI workflows, ensuring that dependency resolution remains consistent without unexpected update cycles.

Highlights

  • CI Configuration: The GitHub Actions workflow for macOS dependencies has been updated to prevent Homebrew commands from automatically triggering an update. This is achieved by setting the HOMEBREW_NO_AUTO_UPDATE environment variable to 1 during the dependency installation step.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the HOMEBREW_NO_AUTO_UPDATE environment variable to the macOS dependency installation step, which prevents Homebrew from running automatic updates. This is a good practice for CI. I've added one comment with a suggestion to further optimize the CI workflow by also removing the explicit brew update call, which would lead to a more significant performance gain.

@xgopilot
Copy link
Contributor

xgopilot bot commented Nov 6, 2025

Overall Assessment: Excellent optimization

This PR makes a focused, well-justified CI performance improvement. Key findings:

  • Performance: Eliminates 30-120s of redundant Homebrew auto-updates per CI run
  • Security: No risks—explicit brew update on line 22 maintains package freshness
  • Code Quality: Properly scoped environment variable following GitHub Actions best practices
  • Low Risk: Backward compatible with no breaking changes

The only suggestion is adding an inline comment explaining the rationale (see inline feedback).

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.98%. Comparing base (d2a2225) to head (cda9d68).
⚠️ Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
+ Coverage   90.18%   90.98%   +0.79%     
==========================================
  Files          43       43              
  Lines       12752    11287    -1465     
==========================================
- Hits        11501    10269    -1232     
+ Misses       1092      859     -233     
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luoliwoshang luoliwoshang force-pushed the ci/no-auto-update branch 3 times, most recently from ae213c4 to f9093e5 Compare November 6, 2025 11:08
@luoliwoshang
Copy link
Member Author

@xushiwei

@xushiwei xushiwei merged commit d368cad into goplus:main Nov 10, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants