Skip to content

Remove redundant CompareString from llgo:skip directive#1352

Merged
xushiwei merged 1 commit intomainfrom
xgopilot/claude/issue-1351-1760682793
Oct 26, 2025
Merged

Remove redundant CompareString from llgo:skip directive#1352
xushiwei merged 1 commit intomainfrom
xgopilot/claude/issue-1351-1760682793

Conversation

@xgopilot
Copy link
Contributor

@xgopilot xgopilot bot commented Oct 17, 2025

Summary

  • Removed redundant CompareString from the llgo:skip init CompareString directive in runtime/internal/lib/internal/bytealg/bytealg.go

Details

The CompareString in the directive was redundant because:

  1. The overlay mechanism automatically handles symbol skipping when an overlay package defines a symbol
  2. There's no need to explicitly declare llgo:skip CompareString
  3. The explicit skip directive was misleading, suggesting special handling was needed when the overlay mechanism handles it automatically

Changes

  • Changed // llgo:skip init CompareString to // llgo:skip init in runtime/internal/lib/internal/bytealg/bytealg.go:26

Fixes #1351

Generated with codeagent

The CompareString in the llgo:skip directive is redundant because
the overlay mechanism automatically handles symbol skipping when
an overlay package defines a symbol.

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: luoliwoshang <luoliwoshang@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (d2a2225) to head (9b39772).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1352   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files          43       43           
  Lines       12752    12752           
=======================================
  Hits        11501    11501           
  Misses       1092     1092           
  Partials      159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luoliwoshang
Copy link
Member

@xushiwei need review

@xushiwei xushiwei merged commit c036243 into main Oct 26, 2025
42 checks passed
@xgopilot xgopilot bot deleted the xgopilot/claude/issue-1351-1760682793 branch October 26, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove redundant llgo:skip CompareString directive

3 participants