ci:fix brew python & update macos-13 -> macos-15

[luoliwoshang]

No description provided.

[niupilot]

🔍 PR Review Complete ✅

Reviewed PR #1329: ci:fix brew python & update macos-13 -> macos-15

---

📋 Review Summary

This PR makes two changes to the CI configuration:

1. macOS Runner Update: Changes from macos-13 to macos-15-intel
2. Python Linking Fix: Adds brew link --overwrite python@3.12 to Ubuntu setup

⚠️ Critical Issue Found

Misplaced Python Command (.github/actions/setup-deps/action.yml:69)

sudo apt-get install -y "${opt_deps[@]}"
brew link --overwrite python@3.12  # ← CRITICAL: Wrong OS section!

Problems:

1. Wrong OS Context: This brew link command is placed in the Ubuntu/Linux section (after sudo apt-get install), but brew is a macOS package manager that doesn't exist on Ubuntu runners
2. Missing Conditional: The command should be inside the macOS section (if: runner.os == 'macOS')
3. Will Break CI: This will cause Ubuntu runners to fail with "command not found: brew"
4. Indentation Issue: Uses tabs instead of spaces, inconsistent with the rest of the YAML file

🔧 Required Fix

Move the Python link command to the macOS section:

1. Remove line 69 (from Ubuntu section):

# DELETE THIS LINE:
brew link --overwrite python@3.12

2. Add to macOS section after line 41:

# In macOS section, after: brew install "${opt_deps[@]}"
brew link --overwrite python@3.12

📝 Minor Observations

macOS Version Update (.github/workflows/release-build.yml:156):

• Change from macos-13 to macos-15-intel appears reasonable
• Consider verifying runner availability and consistency with other jobs using macos-latest

✅ Recommendation

Please fix the misplaced brew command before merging - the current change will break Ubuntu CI runners. The macOS version update looks fine but the Python linking needs to be moved to the correct OS section.

---

👉 Want me to re-run this review? Just type /review in the comments! For more usage examples, visit CodeAgent GitHub Repository.

[gemini-code-assist]

Summary of Changes

Hello @luoliwoshang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a continuous integration stability issue by explicitly linking the python@3.12 Homebrew package. This change is crucial for ensuring that CI workflows correctly identify and utilize the intended Python version, preventing build failures or unexpected behavior related to Python dependencies. The title also indicates an intention to update macOS runners from macos-13 to macos-15, though this specific change is not reflected in the provided patch.

Highlights

• CI Fix for Homebrew Python Linking: Introduced a brew link --overwrite python@3.12 command within the setup-deps GitHub Action. This ensures that the correct Python 3.12 version is properly symlinked in the CI environment, resolving potential conflicts or incorrect Python version usage.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/release-build.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix Python setup on Homebrew for macOS CI runners. The change adds a brew link command to the dependency setup action. However, this command is placed incorrectly within the script, mixing it with a Linux-specific apt-get command, which will cause the CI to fail. My review points out this critical issue and suggests moving the brew command into a macOS-specific conditional block. I also noted an indentation inconsistency.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.10%. Comparing base (8959c83) to head (036bb85).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
- Coverage   90.10%   90.10%   -0.01%     
==========================================
  Files          43       43              
  Lines       12576    12575       -1     
==========================================
- Hits        11332    11331       -1     
  Misses       1088     1088              
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.