feat: support libc/compiler-rt for small places by MeteorsLiu · Pull Request #1246 · goplus/llgo

MeteorsLiu · 2025-08-28T12:12:11Z

Resolves #1248 (Design)

Current support: ESP32

luoliwoshang · 2025-09-01T03:01:32Z

targets/esp32.memory.elf.ld

where is this link script come from

https://github.com/espressif/newlib-esp32/tree/esp-4.3.0/libgloss/xtensa/boards/esp32

luoliwoshang · 2025-09-01T06:10:07Z

targets/esp32.app.elf.ld

where is this .ld come from

https://github.com/espressif/newlib-esp32/tree/esp-4.3.0/libgloss/xtensa/boards/esp32

codecov · 2025-09-02T01:53:41Z

Codecov Report

❌ Patch coverage is 93.24117% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.28%. Comparing base (ddc61ad) to head (977806a).
⚠️ Report is 61 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/crosscompile/fetch.go	70.66%	15 Missing and 7 partials ⚠️
internal/crosscompile/crosscompile.go	71.64%	12 Missing and 7 partials ⚠️
internal/crosscompile/compile/compile.go	94.64%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1246      +/-   ##
==========================================
+ Coverage   87.79%   90.28%   +2.49%     
==========================================
  Files          35       40       +5     
  Lines        8928    11704    +2776     
==========================================
+ Hits         7838    10567    +2729     
- Misses        979     1010      +31     
- Partials      111      127      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fix: libc include dir fix: xtensa internal src dir fix: xtensa internal src dir fix: ignore wasm target fix: export libc cflags to global cflags fix: rtlib libc include dir fix: ignore some errors for libc fix: don's search system path for libc fix: adjust compiling options ci: add libc fix: libc cflags fix: test path fix: libc cflags fix: libc cflags

test: add asm test test: add libc.go test test: add DownloadAndExtractLibInternalDir test test: fix checkDownload test test: fix asm test fix: check isCompile fix: remove debug fix: remove debug

luoliwoshang · 2025-09-02T10:27:13Z

targets/xtensa.json

-	"build-tags": ["xtensa", "baremetal", "linux", "arm"],
+	"build-tags": [
+		"xtensa",
+		"baremetal",
+		"linux",
+		"arm"
+	],


unexpect unuse style change

luoliwoshang · 2025-09-02T10:32:20Z

internal/crosscompile/crosscompile.go

 // If targetName is provided, it takes precedence over goos/goarch
 func Use(goos, goarch string, wasiThreads bool, targetName string) (export Export, err error) {
-	if targetName != "" {
+	if targetName != "" && !strings.HasPrefix(targetName, "wasm") && !strings.HasPrefix(targetName, "wasi") {


Is it because wasm currently doesn't support the --target approach? Also, llgo will indeed have another way to support wasm now. I think we should still leave a comment here to indicate this situation

Crosscompile has been implemented wasm/wasi, those target names are migrated from tinygo, should not useTarget.

luoliwoshang · 2025-09-02T10:33:09Z

internal/crosscompile/compile/rtlib/compiler_rt.go

+				CFlags: []string{
+					"-DNDEBUG",
+					"-DVISIBILITY_HIDDEN",
+				},
+				CCFlags: []string{
+					"-Oz",
+					"-fno-ident",
+					"-Wno-unused-parameter",
+					"-fno-lto",
+					"-Werror=array-bounds",
+					"-Werror=uninitialized",
+					"-Werror=shadow",
+					"-Werror=empty-body",
+					"-Werror=sizeof-pointer-memaccess",
+					"-Werror=sizeof-array-argument",
+					"-Werror=suspicious-memaccess",
+					"-Werror=builtin-memcpy-chk-size",
+					"-Werror=array-bounds-pointer-arithmetic",
+					"-Werror=return-stack-address",
+					"-Werror=sizeof-array-decay",
+					"-Werror=format-insufficient-args",
+					"-Wformat -std=c11",
+					"-fno-builtin",
+					"-fvisibility=hidden",


where is these flags come from?

https://github.com/goplus/compiler-rt/blob/main/CMakeLists.txt

luoliwoshang · 2025-09-02T10:34:06Z

internal/crosscompile/compile/rtlib/compiler_rt.go

+					filepath.Join(baseDir, "lib", "builtins", "absvdi2.c"),
+					filepath.Join(baseDir, "lib", "builtins", "absvsi2.c"),
+					filepath.Join(baseDir, "lib", "builtins", "absvti2.c"),
+					filepath.Join(baseDir, "lib", "builtins", "adddf3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "addsf3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "addvdi3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "addvsi3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "addvti3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "apple_versioning.c"),
+					filepath.Join(baseDir, "lib", "builtins", "ashldi3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "ashlti3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "ashrdi3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "ashrti3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "bswapdi2.c"),
+					filepath.Join(baseDir, "lib", "builtins", "bswapsi2.c"),
+					filepath.Join(baseDir, "lib", "builtins", "clzdi2.c"),


Where does this C language file list come from?

https://github.com/goplus/compiler-rt/blob/main/CMakeLists.txt

cpunion · 2025-09-02T15:01:28Z

internal/crosscompile/compile/rtlib/compiler_rt.go

+					filepath.Join(baseDir, "lib", "builtins", "subtf3.c"),
+					filepath.Join(baseDir, "lib", "builtins", "trunctfdf2.c"),
+					filepath.Join(baseDir, "lib", "builtins", "trunctfhf2.c"),
+					filepath.Join(baseDir, "lib", "builtins", "trunctfsf2.c"),


Split multiline string is better for codegen and tests

luoliwoshang · 2025-09-03T01:56:27Z

_embdemo/hello-esp32/main.go

+package main
+
+import "github.com/goplus/lib/c"
+
+func myprint(s *c.Char) {
+	for i := 0; i < int(c.Strlen(s)); i++ {
+		WriteByte(byte(c.Index(s, i)))
+	}
+}
+
+func main() {
+	for {
+		myprint(c.Str("hello world"))
+		sleep(1)
+	}
+}


#1257 the issue for how to run this demo

MeteorsLiu added 2 commits August 25, 2025 19:05

feat: add libc

5587fd2

feat: support libc for small devices

f3ecce8

MeteorsLiu changed the title ~~[WIP]feat: support libc~~ [WIP]feat: support libc for small places Aug 28, 2025

cpunion mentioned this pull request Aug 29, 2025

Build Target Task 2: Multi-Platform LLVM Support and Bootable Code Generation #1201

Closed

13 tasks

MeteorsLiu added 5 commits August 29, 2025 11:30

feat: support compiler-rt

4639ee1

fix: check needStart by libc name

3f2fe83

fix: newlib url and rt url

61143a6

test: add compile test

19ddee0

fix: remove debug compiler options

53e2248

MeteorsLiu changed the title ~~[WIP]feat: support libc for small places~~ [WIP]feat: support libc/compiler-rt for small places Aug 29, 2025

feat: add target name design

1b3889e

luoliwoshang reviewed Sep 1, 2025

View reviewed changes

MeteorsLiu added 6 commits September 1, 2025 14:48

feat: support riscv32

997ea28

fix: remove unused file

012a5d7

feat: support arm/risc64/avr for compiler rt

8ecbfe9

fix: compiler rt file path

96c5ce9

fix: update url

5997a29

fix: picolibc.h

cb2fa5d

MeteorsLiu force-pushed the esp-libc branch 7 times, most recently from d7fe65e to f860698 Compare September 1, 2025 14:13

MeteorsLiu added 2 commits September 2, 2025 13:40

test: fix compile test

f875347

test: add asm test test: add libc.go test test: add DownloadAndExtractLibInternalDir test test: fix checkDownload test test: fix asm test fix: check isCompile fix: remove debug fix: remove debug

MeteorsLiu force-pushed the esp-libc branch from 72ddf19 to f875347 Compare September 2, 2025 05:42

MeteorsLiu added 5 commits September 2, 2025 17:16

test: skip llgo test

a8bc617

ci: revert

4b383b1

test: add test for compile options

b99c073

test: add rt test

82bb6e8

test: add _embdemo print test

5a4c83e

luoliwoshang reviewed Sep 2, 2025

View reviewed changes

MeteorsLiu marked this pull request as ready for review September 2, 2025 11:08

MeteorsLiu changed the title ~~[WIP]feat: support libc/compiler-rt for small places~~ feat: support libc/compiler-rt for small places Sep 2, 2025

MeteorsLiu added 3 commits September 2, 2025 20:06

test: fix _embdemo

1bd9ceb

test: fix _embdemo write test

dd3c1f9

test: add more libc test

977806a

cpunion reviewed Sep 2, 2025

View reviewed changes

xushiwei merged commit 6588f36 into goplus:main Sep 2, 2025
34 checks passed

luoliwoshang reviewed Sep 3, 2025

View reviewed changes

BrewTestBot mentioned this pull request Nov 15, 2025

llgo 0.11.6 Homebrew/homebrew-core#254512

Merged

Conversation

MeteorsLiu commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luoliwoshang Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MeteorsLiu commented Aug 28, 2025 •

edited

Loading

codecov bot commented Sep 2, 2025 •

edited

Loading

luoliwoshang Sep 3, 2025 •

edited

Loading