internal/target:read targets consist use LLGoROOT#1245
Merged
xushiwei merged 1 commit intogoplus:mainfrom Aug 28, 2025
Merged
Conversation
13 tasks
cpunion
requested changes
Aug 28, 2025
internal/targets/resolver.go
Outdated
| // Assume targets directory is relative to this package | ||
| _, filename, _, _ := runtime.Caller(0) | ||
| projectRoot := filepath.Dir(filepath.Dir(filepath.Dir(filename))) | ||
| projectRoot := env.LLGoROOT() |
luoliwoshang
force-pushed
the
llgo/targetsdir
branch
from
5298eeb to
b68686e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1245 +/- ##
==========================================
- Coverage 87.80% 87.80% -0.01%
==========================================
Files 35 35
Lines 8941 8939 -2
==========================================
- Hits 7851 7849 -2
Misses 979 979
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded runtime.Caller() path calculation with env.LLGoROOT() in targets resolver for consistency with runtime directory resolution.
This aligns targets directory resolution with the existing runtime directory resolution strategy.