Skip to content

Optional esp clang#1233

Merged
xushiwei merged 4 commits intogoplus:mainfrom
cpunion:optional-esp-clang
Sep 8, 2025
Merged

Optional esp clang#1233
xushiwei merged 4 commits intogoplus:mainfrom
cpunion:optional-esp-clang

Conversation

@cpunion
Copy link
Collaborator

@cpunion cpunion commented Aug 24, 2025

  • Prefer to use LLGO_ROOT/cross-compile/clang
  • Use esp clang with -target and without LLGO_ROOT/cross-compile/clang
  • -force-espclang for llgo dev mode

@codecov
Copy link

codecov bot commented Aug 24, 2025

Codecov Report

❌ Patch coverage is 37.93103% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.20%. Comparing base (6588f36) to head (62fc21e).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
internal/crosscompile/crosscompile.go 37.93% 15 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   90.28%   90.20%   -0.08%     
==========================================
  Files          40       40              
  Lines       11704    11712       +8     
==========================================
- Hits        10567    10565       -2     
- Misses       1010     1016       +6     
- Partials      127      131       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-esp-clang

# Conflicts:
#	internal/crosscompile/crosscompile.go
#	internal/crosscompile/crosscompile_test.go
@xushiwei xushiwei merged commit 2f3c322 into goplus:main Sep 8, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants