Skip to content

ssa: PyVal support bool,int,uint,string,complex#1195

Merged
xushiwei merged 1 commit intogoplus:mainfrom
visualfc:pyexpr
Jul 29, 2025
Merged

ssa: PyVal support bool,int,uint,string,complex#1195
xushiwei merged 1 commit intogoplus:mainfrom
visualfc:pyexpr

Conversation

@visualfc
Copy link
Member

@visualfc visualfc commented Jul 29, 2025

fix #1192

  • bool => PyBool
  • int(in8...)/uint(uint8...) => PyLong
  • float32/float64 => PyFloat
  • string => PyString
  • []byte => PyByteArray
  • complex64/complex128 => PyComplex
  • *py.Object => *Object

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 91.58879% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.92%. Comparing base (66fd3a5) to head (0a6588c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ssa/python.go 91.58% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
+ Coverage   87.84%   87.92%   +0.07%     
==========================================
  Files          29       29              
  Lines        7298     7401     +103     
==========================================
+ Hits         6411     6507      +96     
- Misses        821      826       +5     
- Partials       66       68       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@visualfc visualfc force-pushed the pyexpr branch 3 times, most recently from 1cd4ddc to cd719e5 Compare July 29, 2025 07:59
@xushiwei xushiwei merged commit a9193e3 into goplus:main Jul 29, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

panic: PyVal: todo

2 participants