Skip to content

cabi transform#1188

Merged
xushiwei merged 13 commits intogoplus:mainfrom
visualfc:cabi
Aug 19, 2025
Merged

cabi transform#1188
xushiwei merged 13 commits intogoplus:mainfrom
visualfc:cabi

Conversation

@visualfc
Copy link
Member

@visualfc visualfc commented Jul 15, 2025

  • arch
    • amd64
    • arm64
    • wasm ( js, wasip1 )
    • arm
    • riscv64
    • 386
    • riscv32
    • xtensa
  • cfunc
  • all func
  • ABI test arch
    • basic type
    • struct empty
    • struct/array
    • struct mixed
    • struct composite

support cabi transform ( 0=none, 1 = cfunc, 2 = allfunc)

  • llgo -abi (default 2)
  • llgen -abi (default 0)

@visualfc visualfc marked this pull request as draft July 15, 2025 13:13
@codecov
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.99%. Comparing base (b2c6534) to head (04bb3eb).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1188      +/-   ##
==========================================
+ Coverage   87.94%   87.99%   +0.05%     
==========================================
  Files          32       34       +2     
  Lines        7657     8358     +701     
==========================================
+ Hits         6734     7355     +621     
- Misses        844      934      +90     
+ Partials       79       69      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@visualfc visualfc force-pushed the cabi branch 10 times, most recently from 60294d7 to 8ed6092 Compare July 24, 2025 11:22
@visualfc visualfc marked this pull request as ready for review July 24, 2025 11:23
@cpunion
Copy link
Collaborator

cpunion commented Jul 27, 2025

Suggestions

  1. Inline __llgo_cwrap$ Functions

Always inline wrapper functions for better performance.

  1. Remove Wrapper Layer

Directly modify/replace original functions instead of adding __llgo_cwrap$ wrappers.

  1. Global CABI Support

Consider implementing CABI compatibility for all Go methods (can be separate PR).

@visualfc visualfc force-pushed the cabi branch 6 times, most recently from cfba7ab to ad861b0 Compare August 5, 2025 08:27
@visualfc visualfc force-pushed the cabi branch 5 times, most recently from c4fc44e to 50dceb9 Compare August 8, 2025 06:38
@visualfc visualfc changed the title [WIP] cabi transform cabi transform Aug 11, 2025
@visualfc visualfc force-pushed the cabi branch 2 times, most recently from 92a0f43 to ad60359 Compare August 11, 2025 03:33
@visualfc visualfc force-pushed the cabi branch 7 times, most recently from 9d9d2c8 to 686e3b4 Compare August 12, 2025 14:29
@visualfc visualfc force-pushed the cabi branch 3 times, most recently from 13ad277 to c57bcd9 Compare August 13, 2025 08:53
@visualfc visualfc force-pushed the cabi branch 3 times, most recently from 782b672 to 620bd52 Compare August 14, 2025 03:08
@visualfc visualfc force-pushed the cabi branch 4 times, most recently from 543e6b0 to 31971d4 Compare August 15, 2025 02:21
@xushiwei xushiwei merged commit cbac24c into goplus:main Aug 19, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants