Skip to content

refactor(internal/build):remove rpath change#1174

Merged
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:build/rpathmode
Jul 1, 2025
Merged

refactor(internal/build):remove rpath change#1174
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:build/rpathmode

Conversation

@luoliwoshang
Copy link
Member

@luoliwoshang luoliwoshang commented Jun 26, 2025

Based on our discussion in the meeting, the "rpath change mode" only accomplishes half of the publishing task. It is incomplete as it only modifies the library file's install_name to start with @rpath. For commands like llgo run . and llgo build ., implementing the full publishing workflow is too "heavy". Publishing should be treated as a separate solution, and therefore, this mode should be removed.


@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (f0728c4) to head (e60c3bd).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
+ Coverage   87.71%   87.80%   +0.08%     
==========================================
  Files          29       29              
  Lines        7279     7272       -7     
==========================================
  Hits         6385     6385              
+ Misses        827      821       -6     
+ Partials       67       66       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luoliwoshang luoliwoshang marked this pull request as draft June 26, 2025 06:08
luoliwoshang added a commit to luoliwoshang/homebrew-core that referenced this pull request Jun 26, 2025
@luoliwoshang luoliwoshang marked this pull request as ready for review June 26, 2025 06:55
@xushiwei xushiwei merged commit f2c16be into goplus:main Jul 1, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants