refactor(internal/build):remove rpath change#1174
Merged
xushiwei merged 1 commit intogoplus:mainfrom Jul 1, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
+ Coverage 87.71% 87.80% +0.08%
==========================================
Files 29 29
Lines 7279 7272 -7
==========================================
Hits 6385 6385
+ Misses 827 821 -6
+ Partials 67 66 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
luoliwoshang
added a commit
to luoliwoshang/homebrew-core
that referenced
this pull request
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on our discussion in the meeting, the "rpath change mode" only accomplishes half of the publishing task. It is incomplete as it only modifies the library file's install_name to start with @rpath. For commands like llgo run . and llgo build ., implementing the full publishing workflow is too "heavy". Publishing should be treated as a separate solution, and therefore, this mode should be removed.