Skip to content

os:direntNamePtr for array#1173

Merged
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:os/direntNamePtr
Aug 7, 2025
Merged

os:direntNamePtr for array#1173
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:os/direntNamePtr

Conversation

@luoliwoshang
Copy link
Member

@luoliwoshang luoliwoshang commented Jun 26, 2025

fixed #1114

the syscall.Dirent 's name field in macos、linux、bsd are [1024]int8[256]int8[256]uint8[512]int8

name := bytesToString((*[1024]byte)(unsafe.Pointer(direntNamePtr(entry.Name)))[:])

@luoliwoshang luoliwoshang marked this pull request as draft June 26, 2025 02:20
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.71%. Comparing base (f0728c4) to head (417a569).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage   87.71%   87.71%           
=======================================
  Files          29       29           
  Lines        7279     7279           
=======================================
  Hits         6385     6385           
  Misses        827      827           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@luoliwoshang luoliwoshang changed the title os:direntNamePtr for macos os:direntNamePtr for array Jun 26, 2025
@luoliwoshang luoliwoshang marked this pull request as ready for review June 26, 2025 05:44
@xushiwei xushiwei merged commit 1f94cfb into goplus:main Aug 7, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unexpect panic: invalid type in os.ReadDir

2 participants