Skip to content

llcppsymg: support users to modify the symbol mapping table in the llcppg.cfg file #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

llcppsymg: support users to modify the symbol mapping table in the llcppg.cfg file #232

wants to merge 19 commits into from

Conversation

tsingbx
Copy link
Contributor

@tsingbx tsingbx commented Apr 3, 2025

The llcppg.cfg file adds the symMap field to support users to modify the symbol mapping table in the llcppg.cfg file

@tsingbx tsingbx force-pushed the symMap branch 10 times, most recently from bddf395 to 8628ac6 Compare April 9, 2025 02:54
@codecov
Copy link

codecov bot commented Apr 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.73913% with 36 lines in your changes missing coverage. Please review.

Project coverage is 77.07%. Comparing base (a9bca6a) to head (89736ae).

Files with missing lines Patch % Lines
cmd/gogensig/convert/package.go 0.00% 2 Missing and 13 partials ⚠️
llcppg/llcppg.go 16.66% 10 Missing ⚠️
cmd/gogensig/dbg/debug.go 50.00% 8 Missing ⚠️
cmd/gogensig/unmarshal/unmarshal.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
- Coverage   78.85%   77.07%   -1.79%     
==========================================
  Files          31       31              
  Lines        2941     2970      +29     
==========================================
- Hits         2319     2289      -30     
- Misses        604      649      +45     
- Partials       18       32      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsingbx tsingbx force-pushed the symMap branch 4 times, most recently from 878ecc7 to b4c9fb1 Compare April 10, 2025 01:47
luoliwoshang
luoliwoshang reviewed Apr 10, 2025
View reviewed changes
go.mod Outdated
github.com/google/go-cmp v0.6.0
github.com/goplus/gogen v1.16.4
github.com/goplus/llgo v0.10.0
github.com/goplus/llgo v0.10.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
github.com/goplus/llgo v0.10.1
github.com/goplus/llgo v0.10.0

can resolve this fail https://github.com/goplus/llcppg/actions/runs/14370680609/job/40294196011?pr=232

luoliwoshang
luoliwoshang reviewed Apr 10, 2025
View reviewed changes
.github/workflows/go.yml
Comment on lines 49 to 55
- name: Install LLGO
run: |
git clone --branch v0.10.0 https://github.com/goplus/llgo.git
git clone --branch v0.10.1 https://github.com/goplus/llgo.git
echo $PWD
cd llgo/compiler
go install -v ./cmd/...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this pr only aim to support symMap in llcppg.

luoliwoshang
luoliwoshang reviewed Apr 10, 2025
View reviewed changes
llcppg/llcppg.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llcppcfg配置项输出的变化和当前更新无关，不在这个Pr中处理会更合适

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你把https://github.com/goplus/llcppg/pull/245先合并了，就可以合并这个pr

@tsingbx tsingbx force-pushed the symMap branch 5 times, most recently from 1a3f68d to 0c9ab60 Compare April 10, 2025 05:44
@luoliwoshang
Copy link
Member

https://github.com/goplus/llcppg/actions/runs/14373401804/job/40300524017?pr=232
image

这个pr ci fail 提示了当前的实现会让实际的产物缺少某个类型，可以检查一下llcppsymg在sqlite3下是否能输出包含以下内容的出 llcppg.symb.json

{
		"mangle":	"sqlite3_finalize",
		"c++":	"sqlite3_finalize(sqlite3_stmt *)",
		"go":	"(*Stmt).Close"
	}

@tsingbx tsingbx force-pushed the symMap branch 3 times, most recently from eeb9bab to c760784 Compare April 10, 2025 07:43
luoliwoshang
luoliwoshang reviewed Apr 10, 2025
View reviewed changes
_llcppgtest/cjson/demo/hello/hello.go
Comment on lines 1 to 10
package main

import (
"cjson"
"unsafe"

"cjson"

"github.com/goplus/llgo/c"
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

与当前Pr无关的风格问题，需要去除～

luoliwoshang
luoliwoshang reviewed Apr 10, 2025
View reviewed changes
_xtool/llcppsigfetch/dbg/debug.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug的修改单独在一个PR中处理，一个Pr还是尽量做一件事

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你把https://github.com/goplus/llcppg/pull/245先合并了，再合并这个pr

tsingbx added 18 commits April 10, 2025 16:57
@tsingbx
support llcppg.cfg symMap
c6f26db
@tsingbx
delete debug info & fix compile error
fbcb1ce
@tsingbx
change symMap field of llcppg.cfg to map type
f0f62c9
@tsingbx
fix llcppgtest for cjson demo failed
a979ecd
@tsingbx
symMap field of llcppg.cfg support -
e69a01d
@tsingbx
add DbgProcess to control log Process... output
659c729
@tsingbx
add GetDebugNewFuncDecl to control NewFuncDecl log output
8de2206
@tsingbx
add DbgGetCurFile flag to control GetCurFile log output
660c72d
@tsingbx
add GetDebugCollectFuncInfo to control collectFuncInfo log output
6ad3428
@tsingbx
add GetDebugNewSymbol function to control new symbol log output
a772dee
@tsingbx
add GetDebugMacro function to control Macro log output
8397cef
@tsingbx
add debug flag to control debug log output
e101d4b
@tsingbx
add GetDebugWrite function to control Packate write debug log
6b0d13e
@tsingbx
add GetDebugUnmarshalling to control error unmarshalling log
a90cb31
@tsingbx
fix run demos error
617a91d
@tsingbx
change llcppg.symb.json for _llcppgtest
e32d671
@tsingbx
delete llcppg.symb.json
a1a858e
@tsingbx
add tests for dbg
7066a7a
@tsingbx tsingbx closed this Apr 10, 2025
@tsingbx tsingbx reopened this Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luoliwoshang luoliwoshang luoliwoshang left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tsingbx @luoliwoshang