Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LS integration for Completion #1178

Merged
merged 1 commit into from
Dec 26, 2024
Merged

LS integration for Completion #1178

merged 1 commit into from
Dec 26, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Dec 26, 2024

close #1177.

Copy link

qiniu-prow bot commented Dec 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 12 changed files in this pull request and generated 1 comment.

Files not reviewed (7)
  • spx-gui/src/components/editor/code-editor/ui/completion/CompletionCard.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/completion/CompletionItem.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/code-editor.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/common.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/document-base/spx.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/lsp/index.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/lsp/spxls/methods.ts: Evaluated as low risk
Comments suppressed due to low confidence (3)

spx-gui/src/components/editor/code-editor/ui/completion/index.ts:286

  • The condition a.score !== null && b.score !== null is redundant since we are already checking a.score != null && b.score != null. It should be simplified to a.score != null && b.score != null.
} else if (a.score != null && b.score !== null && a.score[0] > b.score[0]) {

spx-gui/src/components/editor/code-editor/ui/completion/index.ts:278

  • [nitpick] Allowing completion to be triggered on dots (.) might not be intended. Confirm if this is the desired behavior.
return /[\w.]/.test(char)

spx-gui/src/components/editor/code-editor/ui/code-editor-ui.ts:240

  • The new method 'insertText' does not have test coverage. Please add tests to cover this new method.
async insertText(text: string, range: Range) {

tools/spxls/internal/server/protocol.go Show resolved Hide resolved
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit a6b1cef into goplus:dev Dec 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LS integration for Completion
3 participants