-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LS integration for Completion #1178
Conversation
Skipping CI for Draft Pull Request. |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 12 changed files in this pull request and generated 1 comment.
Files not reviewed (7)
- spx-gui/src/components/editor/code-editor/ui/completion/CompletionCard.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/completion/CompletionItem.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/code-editor.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/common.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/document-base/spx.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/lsp/index.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/lsp/spxls/methods.ts: Evaluated as low risk
Comments suppressed due to low confidence (3)
spx-gui/src/components/editor/code-editor/ui/completion/index.ts:286
- The condition
a.score !== null && b.score !== null
is redundant since we are already checkinga.score != null && b.score != null
. It should be simplified toa.score != null && b.score != null
.
} else if (a.score != null && b.score !== null && a.score[0] > b.score[0]) {
spx-gui/src/components/editor/code-editor/ui/completion/index.ts:278
- [nitpick] Allowing completion to be triggered on dots (
.
) might not be intended. Confirm if this is the desired behavior.
return /[\w.]/.test(char)
spx-gui/src/components/editor/code-editor/ui/code-editor-ui.ts:240
- The new method 'insertText' does not have test coverage. Please add tests to cover this new method.
async insertText(text: string, range: Range) {
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
close #1177.