Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tools/spxls): correct spx source file formatter #1175

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

aofei
Copy link
Member

@aofei aofei commented Dec 26, 2024

No description provided.

Copy link

qiniu-prow bot commented Dec 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@aofei aofei marked this pull request as ready for review December 26, 2024 06:04
@aofei aofei requested a review from Copilot December 26, 2024 06:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

tools/spxls/internal/server/format.go:106

  • The removal of name.NamePos = goptoken.NoPos could lead to incorrect positioning of variable names in the merged var block. Consider re-adding the line to ensure correct positioning.
firstVarBlock.Specs = append(firstVarBlock.Specs, valueSpec)
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit 481a555 into goplus:dev Dec 26, 2024
7 checks passed
@aofei aofei deleted the spxls-formatting branch December 26, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants