Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use definition from textDocument/documentLink #1174

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Dec 25, 2024

Use definition from textDocument/documentLink for

Copy link

qiniu-prow bot commented Dec 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@@ -67,28 +64,15 @@ const allItems = Object.values({

class ResourceReferencesProvider
extends Emitter<{
didChangeResourceReferences: []
didChangeResourceReferences: [] // TODO
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个跟早上提到的 diagnostics 类似,如果 editor 总是在合适的时候去拉的话,通过事件主动推也就没什么必要了;这里定义先留着,不着急实现

@nighca nighca marked this pull request as ready for review December 26, 2024 06:11
@nighca nighca requested a review from Copilot December 26, 2024 06:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

spx-gui/src/components/editor/code-editor/lsp/index.ts Outdated Show resolved Hide resolved
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit 4308b3d into goplus:dev Dec 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI feature Hover for code editor
3 participants