Tabs for code-editor & Console #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nighca
commented
Dec 23, 2024
•
nighca
commented
- Tabs for code-editor, close Tabs for code editor #1135
- Zoom control for code-editor
- Console UI update
|
Skipping CI for Draft Pull Request. |
nighca
force-pushed
the
issue-1135
branch
2 times, most recently
from
15e9acc to
afa54e3
Compare
nighca
commented
Dec 24, 2024
There was a problem hiding this comment.
原来的 code-editor/ui/markdown/CodeLink.vue 拆成了两个：
code-editor/CodeLink.vue，可用于其他界面模块（如Console）复用code-editor/ui/markdown/CodeLink.ts，基于前者实现，对外提供 string props 方便在 markdown 内容中嵌入使用
There was a problem hiding this comment.
Copilot reviewed 21 out of 36 changed files in this pull request and generated no comments.
Files not reviewed (15)
- spx-gui/src/components/editor/code-editor/ui/definition/DefinitionOverviewWrapper.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/markdown/MarkdownView.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/markdown/CodeView.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/CodeLink.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/markdown/CodeLink.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/document-tab/DocumentTabs.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/document-tab/DocumentTab.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/CodeEditorUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/ZoomControl.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/api-reference/APIReferenceItem.vue: Evaluated as low risk
- spx-gui/src/components/asset/preprocessing/common/ProcessItem.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/diagnostics/DiagnosticsUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/code-editor-ui.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/common.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/context.ts: Evaluated as low risk
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
aofei
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.