Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding-asset from asset-library #1161

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix adding-asset from asset-library #1161

merged 1 commit into from
Dec 20, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Dec 20, 2024

There may be assets with field builder_id in asset-library, which are added by Spritehub rather than Builder.

Now we do control includeID: bool during both export and load processes, allowing us to exclude builder_id when adding asset from asset-library, to avoid issues caused by duplicate ID.

Copy link

qiniu-prow bot commented Dec 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nighca nighca marked this pull request as ready for review December 20, 2024 03:22
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@nighca nighca requested a review from Copilot December 20, 2024 03:29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • spx-gui/src/models/project/index.ts: Evaluated as low risk
  • spx-gui/src/models/sound.ts: Evaluated as low risk
  • spx-gui/src/models/sprite.test.ts: Evaluated as low risk
  • spx-gui/src/models/sprite.ts: Evaluated as low risk
Comments suppressed due to low confidence (4)

spx-gui/src/models/backdrop.ts:51

  • Ensure that the new includeId behavior is covered by tests.
{ includeId = true }: BackdropExportLoadOptions

spx-gui/src/models/common/asset.ts:31

  • The getFiles function should be awaited if it is asynchronous. Ensure that getFiles is awaited to avoid potential issues.
const files = getFiles(assetData.files)

spx-gui/src/models/common/asset.ts:57

  • The getFiles function should be awaited if it is asynchronous. Ensure that getFiles is awaited to avoid potential issues.
const files = getFiles(assetData.files)

spx-gui/src/models/common/asset.ts:75

  • The getFiles function should be awaited if it is asynchronous. Ensure that getFiles is awaited to avoid potential issues.
const files = getFiles(assetData.files)
@aofei aofei merged commit b788f67 into goplus:dev Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants