-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language server integration in code editor - Hover #1158
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件的改动是 PR description 里提到的
Update spx definitions in document-base, related SPX PRs:
没什么营养,不用细看
*/ | ||
'definition-detail': DefinitionDetail | ||
'definition-item': DefinitionItem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新的组件,代替 definition-overview-wrapper
+ definition-detail
,方便 UI 侧去控制二者放一起时的样式
assert.Equal(t, &Hover{ | ||
Contents: MarkupContent{ | ||
Kind: Markdown, | ||
Value: "<definition-item def-id=\"gop:github.com/goplus/spx?Sprite.onStart\" overview=\"func onStart(onStart func())\">\n</definition-item>\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 case 就是早上提到的,预期 def-id name
是 Sprite.onStart
,但是现在会得到 eventSinks.onStart
;感觉修起来有点复杂,我就添个 case 先..
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
Language server integration for Hover, close Language server integration in code editor - Hover #1152
Update spx definitions in document-base, related SPX PRs:
Update style in
MarkdownView
to align with the new designReplace
definition-overview-wrapper
&definition-detail
withdefinition-item