Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server integration in code editor - Hover #1158

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Dec 19, 2024

Copy link

qiniu-prow bot commented Dec 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Collaborator Author

@nighca nighca Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件的改动是 PR description 里提到的

Update spx definitions in document-base, related SPX PRs:

没什么营养,不用细看

*/
'definition-detail': DefinitionDetail
'definition-item': DefinitionItem
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新的组件,代替 definition-overview-wrapper + definition-detail,方便 UI 侧去控制二者放一起时的样式

assert.Equal(t, &Hover{
Contents: MarkupContent{
Kind: Markdown,
Value: "<definition-item def-id=\"gop:github.com/goplus/spx?Sprite.onStart\" overview=\"func onStart(onStart func())\">\n</definition-item>\n",
Copy link
Collaborator Author

@nighca nighca Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 case 就是早上提到的,预期 def-id nameSprite.onStart,但是现在会得到 eventSinks.onStart;感觉修起来有点复杂,我就添个 case 先..

@nighca nighca marked this pull request as ready for review December 20, 2024 07:33
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit 303dc12 into goplus:dev Dec 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language server integration in code editor - Hover
3 participants