-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language server integration in code editor - Rename Resources #1155
Conversation
Skipping CI for Draft Pull Request. |
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 44 out of 59 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- spx-gui/src/components/editor/code-editor/ui/CodeEditorUI.vue: Evaluated as low risk
- spx-gui/src/components/editor/EditorContextProvider.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/CodeEditor.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/FormatButton.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/completion/CompletionCard.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/api-reference/APIReferenceItem.vue: Evaluated as low risk
- spx-gui/src/components/asset/RenameModal.vue: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/MonacoEditor.vue: Evaluated as low risk
- spx-gui/src/components/asset/index.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/common.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/code-editor-ui.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/ui/api-reference/index.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/lsp/index.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/document-base/index.ts: Evaluated as low risk
- spx-gui/src/components/editor/code-editor/copilot.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)
spx-gui/src/components/editor/code-editor/code-editor.ts:182
- The 'formatTextDocument' method is not yet implemented. Ensure this functionality is covered by tests once implemented.
console.warn('TODO: format', id)
@nighca: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
close #1153.
LS integration for "Rename Resources"
Refactor
CodeEditor
CodeEditor
: Manages code-editing behavior for the entire project, maintaining shared states across allCodeEditorUI
sCodeEditorUI
: Represents the editing-UI for a single code file, rendered in someSpriteEditor
orStageEditor
Extract component
RenameModal
for different resources' renamingDefine
ResourceModel
in@/models
, which is now a global concept across the application