Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language server integration in code editor - Rename Resources #1155

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Dec 18, 2024

close #1153.

  • LS integration for "Rename Resources"

  • Refactor CodeEditor

    • CodeEditor: Manages code-editing behavior for the entire project, maintaining shared states across all CodeEditorUIs
    • CodeEditorUI: Represents the editing-UI for a single code file, rendered in some SpriteEditor or StageEditor
  • Extract component RenameModal for different resources' renaming

  • Define ResourceModel in @/models, which is now a global concept across the application

Copy link

qiniu-prow bot commented Dec 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 44 out of 59 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • spx-gui/src/components/editor/code-editor/ui/CodeEditorUI.vue: Evaluated as low risk
  • spx-gui/src/components/editor/EditorContextProvider.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/CodeEditor.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/FormatButton.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/completion/CompletionCard.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/api-reference/APIReferenceItem.vue: Evaluated as low risk
  • spx-gui/src/components/asset/RenameModal.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/MonacoEditor.vue: Evaluated as low risk
  • spx-gui/src/components/asset/index.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/common.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/code-editor-ui.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/api-reference/index.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/lsp/index.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/document-base/index.ts: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/copilot.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

spx-gui/src/components/editor/code-editor/code-editor.ts:182

  • The 'formatTextDocument' method is not yet implemented. Ensure this functionality is covered by tests once implemented.
console.warn('TODO: format', id)

spx-gui/src/components/editor/code-editor/text-document.ts Outdated Show resolved Hide resolved
@nighca nighca marked this pull request as ready for review December 19, 2024 08:09
Copy link

qiniu-prow bot commented Dec 19, 2024

@nighca: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
goplus-builder-pr-review-environment-test f84f111 link true /test goplus-builder-pr-review-environment-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nighca nighca merged commit bd404d2 into goplus:dev Dec 20, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language server integration in code editor - Rename Resources
2 participants