Feature/flag quiet #185
Merged
Feature/flag quiet #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏 Thanks for opening this pull request! Please check out our contributing guidelines. |
|
🙏 Thank your for raising your pull request. |
gopinath-langote
requested changes
Mar 20, 2020
|
Issues
======
- Added 1
See the complete overview on Codacy |
|
Let me know if you need any help from my side. |
|
@gopinath-langote Please Review. |
|
@ashupatil96 LGTM. Thanks for the PR. This was a long waiting feature for me. |
|
Congrats on merging your first pull request! We here at 1build are proud of you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes developers choose to not see all logs/output of your command and just see success or failure as the outcome. Hence adding --quiet or -q flag to 1build command execution will result in just executing the command but not showing the entire output of it.
Fixes/Implements: #140
New dependencies introduced
Reason: Viper has the ability to bind to flags. To bind flag --quiet flag throughout project(particularly exec.go)
Checklist