Fix checking for invalid names used in unset #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add invalid name check for all commands passed to unset - Add tests
|
🙏 Thank your for raising your pull request. |
This commit fixex the error raised by Reviewdog: "regexp.MatchString in a loop has poor performance, consider using regexp.Compile (staticcheck)"
Changes are based on the following comment by reviewdog: "regexpMust: for const patterns like `^[a-zA-Z0-9\-_]+$`, use regexp.MustCompile"
gopinath-langote
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the way invalid command names are checked in
unset. The existing implementation only checks the first command name, this PR makes sure all commands passed tounsetare checked.Fixes/Implements: # (issue)
Handle invalid command names passed to
unsetcommandIf New dependencies introduced
None
Checklist