Add phase banners to the tops of each phase #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏 Thanks for opening this pull request! Please check out our contributing guidelines. |
|
🙏 Thank your for raising your pull request. |
gopinath-langote
added
Hacktoberfest
ian-howell
force-pushed
the
phase-banners
branch
from
bacd6b6 to
0eae1f1
Compare
We need the literal number of spaces a command *is* taking up, as opposed to the width of its unicode character, or the width that it *should* take up on the screen. E.g. The smiley emoji, described by the 3 bytes [0xE2 0x98 0xBA] takes up 2 columns on the screen, but only occupies 1 column, as seen below 1234567 ###☺###
ian-howell
force-pushed
the
phase-banners
branch
from
0eae1f1 to
d370578
Compare
gopinath-langote
approved these changes
Sep 30, 2019
|
Congrats on merging your first pull request! We here at 1build are proud of you! 🙏 |
themayurkumbhar
pushed a commit
to themayurkumbhar/1build
that referenced
this pull request
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds banners to the tops of each phase. This makes it easier to follow the flow in a multi-phase alias.
Fixes/Implements: #154
Checklist:
Notes to reviewer
This prints the banner unconditionally, whether it is a command, a before, or an after. This also prints the banner even if the command fails. I personally think this constantness is a good thing, allowing a user to see exactly what happened during execution (and exactly which step failed), but I will gladly change it if desired.