Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unset multiple command in one go #141

Closed
gopinath-langote opened this issue Sep 17, 2019 · 5 comments
Closed

Unset multiple command in one go #141

gopinath-langote opened this issue Sep 17, 2019 · 5 comments
Assignees
@boonwj
Labels
enhancement New feature or request good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/
Milestone
v1.4.0

Comments

@gopinath-langote
Copy link
Owner

Description

Current version support unset one command like 1build unset test. If developer has to remove multiple commands they have to run 1build unset multiple times.

Instead With 1build unset a b c -> It will be easy to remove three commands in one go.

Acceptance Criteria

  • Ability to pass multiple commands to unset
  • unset will continue removing next command even after the failure of one
  • unset will print if any command failed to remove
@gopinath-langote gopinath-langote added enhancement New feature or request good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed labels Sep 17, 2019
@gopinath-langote gopinath-langote modified the milestones: v2.0.0, v1.3.0 Sep 17, 2019
@pradeepmurugesan
Copy link

I can work on this..

@gopinath-langote
Copy link
Owner Author

@pradeepmurugesan sure.

@gopinath-langote gopinath-langote added In Progress Someone working on the issue and removed help wanted Extra attention is needed labels Sep 25, 2019
@boonwj boonwj mentioned this issue Sep 26, 2019
Merged
3 tasks
@boonwj
Copy link
Contributor

boonwj commented Sep 26, 2019

I have created a small PR that implements this functionality.

Sorry for failing to mention earlier that I was also looking into this 😔

boonwj added a commit to boonwj/1build that referenced this issue Sep 26, 2019
@boonwj
Add feature to unset multiple commands at once
735f4ac 
Allow multiple command names to be passed to unset.

Each command name will be processed in sequence, if not found, a failure
to remove message will be printed and the action will continue.

ref: gopinath-langote#141
@gopinath-langote
Copy link
Owner Author

Feel free to open PRs. We will review all PRs on same issue.

@boonwj From next time onwards - It will be good if you can comment on the issue that you would like to work :) So that others will not take the same PR.

@pradeepmurugesan pradeepmurugesan removed their assignment Sep 26, 2019
@gopinath-langote gopinath-langote removed the In Progress Someone working on the issue label Sep 27, 2019
@gopinath-langote
Copy link
Owner Author

@boonwj Thanks for the PR.

@pradeepmurugesan You can pick any other ope issue. Sorry for the inconvenience caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boonwj boonwj

Labels
enhancement New feature or request good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
3 participants
@pradeepmurugesan @boonwj @gopinath-langote