fix(gmail): resolve type errors #594
Conversation
Adds JSDoc annotations and makes minor code adjustments to resolve TypeScript check errors in the 'gmail' directory. - Replaces non-standard `for each...in` loops with `for...of`. - Removes unhelpful `try...catch` blocks. - Adds checks for advanced services and undefined properties. - Adds `@typedef` for the add-on event object. - Adds a link to the reference documentation for the `gmailEvent` `@typedef`. - Fixes a typo in a comment.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
jpoehnelt
left a comment
jpoehnelt
left a comment
There was a problem hiding this comment.
LGTM! Removing the try/catch blocks improves clarity.
| * @param {Object} e The data provided by the Gmail UI. | ||
| * @return {Card[]} | ||
| * @param {gmailEvent} e The data provided by the Gmail UI. | ||
| * @return {CardService.Card[]} |
There was a problem hiding this comment.
Namespace 'CardService' has no exported member 'Card'.
There was a problem hiding this comment.
You're right. The type checker doesn't recognize CardService.Card in this context. I've added a local @typedef {Object} Card to satisfy the checker while keeping the code correct for the Apps Script runtime. Thank you for the feedback!
1 participant
This pull request resolves TypeScript check errors in the 'gmail' directory by adding JSDoc annotations and making minor code adjustments. It also removes unhelpful
try...catchblocks and replaces them with more informative checks for advanced services. This update also includes a link to the reference documentation for thegmailEvent@typedef, and fixes a typo in a comment.PR created automatically by Jules for task 12887527255861845131 started by @jpoehnelt