Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix take picture with low resolution #268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix take picture with low resolution #268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb59dca
Make sure supportedPictureSizes order from large to small
IvanBean Oct 2, 2017
7b95445
Make sure supportedPictureSizes order from highest to lowest
IvanBean Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...main/java/com/google/android/gms/samples/vision/barcodereader/ui/camera/CameraSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import java.lang.annotation.RetentionPolicy;
import java.nio.ByteBuffer;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -909,6 +910,12 @@ private static List<SizePair> generateValidPreviewSizeList(Camera camera) {
parameters.getSupportedPreviewSizes();
List<android.hardware.Camera.Size> supportedPictureSizes =
parameters.getSupportedPictureSizes();

int lastIndex = supportedPictureSizes.size() - 1;
if (supportedPictureSizes.get(0).height < supportedPictureSizes.get(lastIndex).height) {
Collections.reverse(supportedPictureSizes);
}

List<SizePair> validPreviewSizes = new ArrayList<>();
for (android.hardware.Camera.Size previewSize : supportedPreviewSizes) {
float previewAspectRatio = (float) previewSize.width / (float) previewSize.height;
Expand Down