Skip to content

Misc fixes for web components demos #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Misc fixes for web components demos #1733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1dc768e
add "maps" to libraries
chrisjshull May 14, 2024
da366c0
Update style.scss to remove redundant styles
chrisjshull May 14, 2024
62b48f0
remove unneeded map-id="DEMO_MAP_ID"
chrisjshull May 14, 2024
e7656a0
Update web-components-markers.json to add maps library
chrisjshull May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/web-components-map/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
-->
{% extends '../../src/_includes/layout.njk'%} {% block html %}
<!-- [START maps_web_components_map_gmpmap] -->
<gmp-map center="37.4220656,-122.0840897" zoom="10" map-id="DEMO_MAP_ID" style="height: 400px"></gmp-map>
<gmp-map center="37.4220656,-122.0840897" zoom="10" style="height: 400px"></gmp-map>
<!-- [END maps_web_components_map_gmpmap] -->
{% endblock %}
4 changes: 2 additions & 2 deletions samples/web-components-map/web-components-map.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"title": "Add a Map using HTML",
"callback": "initMap",
"libraries": [],
"libraries": ["maps"],
"version": "beta",
"tag": "web_components_map",
"name": "web-components-map",
Expand All @@ -11,4 +11,4 @@
"alias": "mode"
},
"permalink": "samples/{{ page.fileSlug }}/{{mode}}/{% if mode == 'jsfiddle' %}demo{% else %}index{% endif %}.{{ page.outputFileExtension }}"
}
}
4 changes: 0 additions & 4 deletions samples/web-components-markers/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,4 @@
/* [START maps_web_components_markers] */
@include meta.load-css("../../shared/scss/default.scss");

gmp-map {
height: 400px;
}

/* [END maps_web_components_markers] */
4 changes: 2 additions & 2 deletions samples/web-components-markers/web-components-markers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"title": "Add a Map with Markers using HTML",
"callback": "initMap",
"libraries": ["marker"],
"libraries": ["maps", "marker"],
"version": "beta",
"tag": "web_components_markers",
"name": "web-components-markers",
Expand All @@ -11,4 +11,4 @@
"alias": "mode"
},
"permalink": "samples/{{ page.fileSlug }}/{{mode}}/{% if mode == 'jsfiddle' %}demo{% else %}index{% endif %}.{{ page.outputFileExtension }}"
}
}