Fix for AKS recent provider change #1380

aLekSer · 2020-03-02T15:07:28Z

Remove deprecation warnings for AKS and EKS syntax : "${}"

About 6 days ago there was an update of AzureRM terraform provider, which broke AKS terraform config:
https://stackoverflow.com/questions/60384689/terraform-azurerm-2-x-error-features-required-field-is-not-set

aLekSer · 2020-03-02T15:07:52Z

This is the ticket
hashicorp/terraform-provider-azurerm#5867

agones-bot · 2020-03-02T15:38:43Z

Build Succeeded 👏

Build Id: 7fac7462-38c1-4af0-9fbd-15f8a2d0f7c4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-751ad23
image: gcr.io/agones-images/agones-sdk:1.4.0-751ad23
image: gcr.io/agones-images/agones-ping:1.4.0-751ad23
Linux C++ SDK (build): agonessdk-1.4.0-751ad23-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-751ad23.zip

A preview of the website (the last 30 builds are retained):

https://751ad23-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1380/head:pr_1380 && git checkout pr_1380
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-751ad23

agones-bot · 2020-03-02T16:40:02Z

Build Failed 😱

Build Id: 908b4bed-d132-43da-ba4c-63ec881db53c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-02T19:45:08Z

Build Succeeded 👏

Build Id: da25991f-618e-42e7-941d-7f79770484f8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-a6c5772
image: gcr.io/agones-images/agones-sdk:1.4.0-a6c5772
image: gcr.io/agones-images/agones-ping:1.4.0-a6c5772
Linux C++ SDK (build): agonessdk-1.4.0-a6c5772-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-a6c5772.zip

A preview of the website (the last 30 builds are retained):

https://a6c5772-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1380/head:pr_1380 && git checkout pr_1380
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-a6c5772

agones-bot · 2020-03-03T06:49:52Z

Build Succeeded 👏

Build Id: fba82916-e4e7-4833-bb0d-d0ba0ce3cd30

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-97c917d
image: gcr.io/agones-images/agones-sdk:1.4.0-97c917d
image: gcr.io/agones-images/agones-ping:1.4.0-97c917d
Linux C++ SDK (build): agonessdk-1.4.0-97c917d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-97c917d.zip

A preview of the website (the last 30 builds are retained):

https://97c917d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1380/head:pr_1380 && git checkout pr_1380
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-97c917d

agones-bot · 2020-03-03T14:07:02Z

Build Succeeded 👏

Build Id: e59fbbe0-1ee6-4615-b4b9-31a061e0a3f1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-a88f441
image: gcr.io/agones-images/agones-sdk:1.4.0-a88f441
image: gcr.io/agones-images/agones-ping:1.4.0-a88f441
Linux C++ SDK (build): agonessdk-1.4.0-a88f441-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-a88f441.zip

A preview of the website (the last 30 builds are retained):

https://a88f441-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1380/head:pr_1380 && git checkout pr_1380
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-a88f441

agones-bot · 2020-03-03T14:21:45Z

Build Failed 😱

Build Id: e679ada4-966c-4628-a4e0-88919f884a89

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-03-03T14:54:07Z

This PR is ready for review.
There are 2 commented out lines.

I will add this in an upcoming release :

enable_node_public_ip = true

(current approach with opening a PublicIP works here as well https://agones.dev/site/docs/installation/creating-cluster/aks/#creating-and-assigning-public-ips-to-nodes )

I have noticed strange error message in build e679ada4-..
e679ada4-

Step #22: time="2020-03-03 14:17:49.151" level=info msg="fleet simple-fleet-tnwnh has 3/3 ready replicas"
Step #22: time="2020-03-03 14:17:49.213" level=info msg="failing PostAllocate request" error="rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = \"transport: authentication handshake failed: x509: cannot validate certificate for 35.247.4.172 because it doesn't contain any IP SANs\""
Step #22: time="2020-03-03 14:17:56.022" level=info msg="waiting for fleet condition" fleet=simple-fleet-v8jd9
Step #22: time="2020-03-03 14:17:56.054" level=info msg="fleet simple-fleet-v8jd9 has 0/3 ready replicas"
Step #22: time="2020-03-03 14:17:58.062" level=info msg="fleet simple-fleet-v8jd9 has 0/3 ready replicas"

agones-bot · 2020-03-03T15:06:11Z

Build Succeeded 👏

Build Id: e8ae770f-72a5-4fd4-896a-64a5b703d6c3

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-4cf8cca
image: gcr.io/agones-images/agones-sdk:1.4.0-4cf8cca
image: gcr.io/agones-images/agones-ping:1.4.0-4cf8cca
Linux C++ SDK (build): agonessdk-1.4.0-4cf8cca-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-4cf8cca.zip

A preview of the website (the last 30 builds are retained):

https://4cf8cca-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1380/head:pr_1380 && git checkout pr_1380
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-4cf8cca

markmandel

Only one small nit, but otherwise, looks great 👍

markmandel · 2020-03-03T20:03:17Z

install/terraform/modules/aks/aks.tf

+  node_taints           = ["agones.dev/agones-system=true:NoExecute"]
+}
+
+/*


Nit: remove commented out code.

Sorry, this code was added due to my quota (of 4 VMs) limit has reached.
Tested with:

terraform apply -var client_id=cb... -var client_secret=9e... -var node_count=1 --auto-approve

All is fine with this Metrics block also so adding this.

agones-bot · 2020-03-04T08:16:25Z

Build Failed 😱

Build Id: d39e47f9-7b45-4aab-9e30-190dce6e29a4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-04T08:21:48Z

Build Failed 😱

Build Id: 5822f1a5-8c96-48eb-996f-761fb02a877c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-04T08:47:09Z

Build Failed 😱

Build Id: 20902e0b-0efd-475b-9c49-7698cd320376

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-03-04T09:17:09Z

Bingo situation: 2 times TestGameServerReserve failures out of 3, hope that it would be fixed soon.
And one time this:

Step #22: --- FAIL: TestAllocator (1.41s)
Step #22:     allocator_test.go:61: deleting pods failed: pods "agones-allocator-c898bf597-w42zk" not found

It could be the time when we need to clean E2E cluster.

agones-bot · 2020-03-04T09:48:45Z

Build Succeeded 👏

Build Id: 6024759e-0172-4057-b1f4-99fcc925879d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-0fb747e
image: gcr.io/agones-images/agones-sdk:1.4.0-0fb747e
image: gcr.io/agones-images/agones-ping:1.4.0-0fb747e
Linux C++ SDK (build): agonessdk-1.4.0-0fb747e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-0fb747e.zip

A preview of the website (the last 30 builds are retained):

https://0fb747e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1380/head:pr_1380 && git checkout pr_1380
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-0fb747e

markmandel · 2020-03-05T23:24:17Z

install/terraform/modules/aks/aks.tf

@@ -45,33 +53,56 @@ resource "azurerm_resource_group" "test" {
 }

 resource "azurerm_kubernetes_cluster" "test" {


I'm not seeing anything here that should block this going through - but I am curious why lots of things are called "test"?

Is that a Terraform thing? Seems like there would be a better name?

This was caused by copying an example config of Azure Terraform provider.
I will add more meaningful names

agones-bot · 2020-03-06T16:26:37Z

Build Failed 😱

Build Id: 1e70adbd-0003-4234-89ff-fff27b94c542

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Fix old version for azurerm terraform provider, new version needs `features = {}` so it does not backward compatible. Remove deprecation warnings for AKS and EKS syntax : "${}"

agones-bot · 2020-03-06T16:57:57Z

Build Failed 😱

Build Id: c3f5192f-ee7b-4b98-9c0d-055bc8d581f5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-09T14:54:39Z

Build Failed 😱

Build Id: 49abea39-5553-476d-8552-6e29f222c6e1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

👍

google-oss-robot · 2020-03-13T22:44:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-03-13T23:42:02Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-03-14T00:00:40Z

Build Succeeded 👏

Build Id: c84c9002-edc1-4229-b3ec-d68f3c4e6462

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-b67d110
image: gcr.io/agones-images/agones-sdk:1.5.0-b67d110
image: gcr.io/agones-images/agones-ping:1.5.0-b67d110
Linux C++ SDK (build): agonessdk-1.5.0-b67d110-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-b67d110.zip

A preview of the website (the last 30 builds are retained):

https://b67d110-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1380/head:pr_1380 && git checkout pr_1380
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-b67d110

Fix old version for azurerm terraform provider, new version needs `features = {}` so it does not backward compatible. Remove deprecation warnings for AKS and EKS syntax : "${}" Co-authored-by: Mark Mandel <[email protected]>

google-oss-robot requested review from EricFortin and markmandel March 2, 2020 15:07

google-oss-robot added the size/M label Mar 2, 2020

aLekSer force-pushed the fix/aks-terraform branch from 751ad23 to 3e98713 Compare March 2, 2020 16:25

google-oss-robot added size/L and removed size/M labels Mar 2, 2020

aLekSer force-pushed the fix/aks-terraform branch from 3e98713 to a6c5772 Compare March 2, 2020 19:29

aLekSer added the do-not-merge/work-in-progress label Mar 2, 2020

aLekSer force-pushed the fix/aks-terraform branch from a6c5772 to 97c917d Compare March 3, 2020 06:33

aLekSer force-pushed the fix/aks-terraform branch 2 times, most recently from a88f441 to dff8d6b Compare March 3, 2020 14:06

aLekSer removed the do-not-merge/work-in-progress label Mar 3, 2020

aLekSer force-pushed the fix/aks-terraform branch from dff8d6b to 4cf8cca Compare March 3, 2020 14:49

markmandel reviewed Mar 3, 2020

View reviewed changes

aLekSer force-pushed the fix/aks-terraform branch 2 times, most recently from b29e25c to afdbcd0 Compare March 4, 2020 08:05

aLekSer force-pushed the fix/aks-terraform branch from afdbcd0 to 7b4532e Compare March 4, 2020 08:32

aLekSer force-pushed the fix/aks-terraform branch from 7b4532e to 0fb747e Compare March 4, 2020 09:30

markmandel reviewed Mar 5, 2020

View reviewed changes

aLekSer force-pushed the fix/aks-terraform branch from 0fb747e to 3a05210 Compare March 6, 2020 16:12

Fix for AKS recent provider change

c0eecc6

Fix old version for azurerm terraform provider, new version needs `features = {}` so it does not backward compatible. Remove deprecation warnings for AKS and EKS syntax : "${}"

aLekSer force-pushed the fix/aks-terraform branch from 3a05210 to c0eecc6 Compare March 6, 2020 16:43

Merge branch 'master' into fix/aks-terraform

5fc6656

markmandel approved these changes Mar 13, 2020

View reviewed changes

google-oss-robot assigned markmandel Mar 13, 2020

google-oss-robot added the lgtm label Mar 13, 2020

google-oss-robot added the approved label Mar 13, 2020

markmandel added area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc labels Mar 13, 2020

Merge branch 'master' into fix/aks-terraform

b67d110

google-oss-robot removed the lgtm label Mar 13, 2020

markmandel merged commit d2614df into googleforgames:master Mar 14, 2020

markmandel added this to the 1.5.0 milestone Mar 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for AKS recent provider change #1380

Fix for AKS recent provider change #1380

aLekSer commented Mar 2, 2020

aLekSer commented Mar 2, 2020

agones-bot commented Mar 2, 2020

agones-bot commented Mar 2, 2020

agones-bot commented Mar 2, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

aLekSer commented Mar 3, 2020

agones-bot commented Mar 3, 2020

markmandel left a comment

markmandel Mar 3, 2020

aLekSer Mar 4, 2020 •

edited

Loading

agones-bot commented Mar 4, 2020

agones-bot commented Mar 4, 2020

agones-bot commented Mar 4, 2020

aLekSer commented Mar 4, 2020 •

edited

Loading

agones-bot commented Mar 4, 2020

markmandel Mar 5, 2020

aLekSer Mar 6, 2020 •

edited

Loading

agones-bot commented Mar 6, 2020

agones-bot commented Mar 6, 2020

agones-bot commented Mar 9, 2020

markmandel left a comment

google-oss-robot commented Mar 13, 2020

google-oss-robot commented Mar 13, 2020

agones-bot commented Mar 14, 2020

		@@ -45,33 +53,56 @@ resource "azurerm_resource_group" "test" {
		}

		resource "azurerm_kubernetes_cluster" "test" {

Fix for AKS recent provider change #1380

Fix for AKS recent provider change #1380

Conversation

aLekSer commented Mar 2, 2020

aLekSer commented Mar 2, 2020

agones-bot commented Mar 2, 2020

agones-bot commented Mar 2, 2020

agones-bot commented Mar 2, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

aLekSer commented Mar 3, 2020

agones-bot commented Mar 3, 2020

markmandel left a comment

Choose a reason for hiding this comment

markmandel Mar 3, 2020

Choose a reason for hiding this comment

aLekSer Mar 4, 2020 • edited Loading

Choose a reason for hiding this comment

agones-bot commented Mar 4, 2020

agones-bot commented Mar 4, 2020

agones-bot commented Mar 4, 2020

aLekSer commented Mar 4, 2020 • edited Loading

agones-bot commented Mar 4, 2020

markmandel Mar 5, 2020

Choose a reason for hiding this comment

aLekSer Mar 6, 2020 • edited Loading

Choose a reason for hiding this comment

agones-bot commented Mar 6, 2020

agones-bot commented Mar 6, 2020

agones-bot commented Mar 9, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Mar 13, 2020

google-oss-robot commented Mar 13, 2020

agones-bot commented Mar 14, 2020

aLekSer Mar 4, 2020 •

edited

Loading

aLekSer commented Mar 4, 2020 •

edited

Loading

aLekSer Mar 6, 2020 •

edited

Loading