-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestGameServerEvicted won't work on Autopilot #2890
Labels
Comments
zmerlynn
added a commit
that referenced
this issue
Jan 23, 2023
Run e2e tests against Autopilot 1.24 cluster. Mark as `allowFailure` for now just to get a sense for whether it works - I will manually scan CI after this goes in. We probably should script additions/mutations to this in the future... Along the way: Skip the TestGameServerEvicted on Autopilot, filed #2890
igooch
pushed a commit
to igooch/agones
that referenced
this issue
Jan 31, 2023
Run e2e tests against Autopilot 1.24 cluster. Mark as `allowFailure` for now just to get a sense for whether it works - I will manually scan CI after this goes in. We probably should script additions/mutations to this in the future... Along the way: Skip the TestGameServerEvicted on Autopilot, filed googleforgames#2890
'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions ' |
@zmerlynn you want to leave this open? |
Yeah, labeled! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Autopilot adjusts resource requests to minimums: From here: The ephemeral storage limit must be within 10 MiB and 10 GiB for all compute classes and hardware configurations.
TestGameServerEvicted
uses a 0Mi ephemeral storage limit to force the game server pod to be evicted. Unfortunately, this won't work on Autopilot. A proposed solution would be to havesimple-game-server
(when an option is enabled) either spike storage or memory on startup and force an eviction.I do not think this is blocking as we have coverage of this case in other parts of the matrix, so I'm going to mark it to be skipped on Autopilot.
Tracking towards #2777, though may call that done before I get to this.
The text was updated successfully, but these errors were encountered: