Make importlib_resources optional #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of reducing the number of dependencies, require
importlib_resourcesonly on Python < 3.10. I think tools likeshedcan automatically delete the if-else checks if the minimum Python version is lifted eventually.importlib.resources.fileswas added in Py 3.9 but testing it there raised some error I didn't feel like investigating, so I gated the dep on 3.10 instead.Also added a tox config for easy testing. Did you know that you can install tox-uv alongside your tox and uv will automatically download Python versions you don't have? Makes testing across versions very easy. Also, did you know about
tox p? Makes it time-efficient as well!Side-note: testing on Py 3.8 and 3.9, where importlib_resources is used, takes 250 seconds on my machine, whereas with the newer versions it takes around 50 seconds. Make of that what you will.