Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete arabic control characters mark-ar (0x061C) and lefttorightmark (0x200E) #176

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

yanone
Copy link
Contributor

@yanone yanone commented Oct 24, 2024

These are invisible control characters and are confusing when part of glyphsets.

I used search-and-replace, so the files should be good despite the characters being invisible.

@yanone
Copy link
Contributor Author

yanone commented Oct 24, 2024

Could you please publish a package update after merging this? Thank you.

@moyogo
Copy link
Contributor

moyogo commented Oct 25, 2024

I think this can be merged. However, knowing these characters are used can still be useful at other level of language support so it would be good to have other opinions.

@yanone
Copy link
Contributor Author

yanone commented Oct 25, 2024

That's an interesting point. If they shall stay in the language DB, I could instead maybe filter for invisible control characters when assembling the glyphsets, leaving the languages untouched here.

@yanone
Copy link
Contributor Author

yanone commented Oct 26, 2024

I just implemented a filter for Cc and Cf Unicode category characters in glyphsets and it removes exactly those two plus a third righttoleftmark in Arabic Plus that I didn’t catch earlier.

Personally I’m happy with this and will let you decide whether to close the PR or not.

@simoncozens
Copy link
Contributor

I think control characters don't belong in these lists.

@simoncozens simoncozens merged commit df8b281 into main Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants